-
Notifications
You must be signed in to change notification settings - Fork 325
added task by vivek #1171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added task by vivek #1171
Conversation
Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. In the meantime, please ensure that your changes align with our CONTRIBUTING.md. If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊 |
Fixed: #1154 |
@sanjay-kv, me and @aditya-bhaumik co authored and solved. |
@vivekvardhan2810 @aditya-bhaumik why is it static? and what does the progress bar mean? "5/10 closed" what? |
The progress bar means that we can know the status of that particular folder, whereas “5/10 closed” indicates that 5 out of 10 tasks, items, or stages have been completed or resolved. And we added extra cards so that there are some 50 percent ones also all of the ones in the repo are 100 And Which was not looking good So that's why. |
@vivekvardhan2810 @aditya-bhaumik I guess writing |
@vansh-codes no it will not look nice |
@vansh-codes i made according to the image sanjay gave me in issue which assigned to me. So i have added And there is no need As It is mentioned total and closed Lets say you have 40 total issues on that project and there are only 20 done till now, There will be still 20 left, from this we can understand and we know so that it will be more informative How is that method is going to help. |
okay @aditya-bhaumik @vivekvardhan2810 ✅ |
@shreyash3087 its static because all of the projects are done so all are 10/10 or 20/20 which is 100 percent and i dont think new issues will be added as for the extra cards we added them because all the cards had 100 So added a 2 - 3 50 percent also |
@aditya-bhaumik @vivekvardhan2810, you both work on this together as co-authors right? I only see Vivek’s commits with code additions and @aditya-bhaumik’s three deletions of "empty space". Did you discuss the code and collaborate, with Vivek making the actual code changes? Or is this just for the badge purpose? |
Yes @MastanSayyad |
@MastanSayyad check the issue once which was assigned to vivek once and we both already have the badge You can just do gmeet through whatsapp with the person you are collabrating makes the work so much easier |
@MastanSayyad both of us worked on it together should not matter who made the commit |
Yeah, no worries! Was just curious as it was static. |
@sanjay-kv